Set application name in macOS driver #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You'd commonly want to rebase instead of adding a merge commit as those cause problems. |
It builds fine on my machine. I don't know of any problems on my end. |
JoshuaBrest
added a commit
to JoshuaBrest/whisky-wine
that referenced
this pull request
Jul 23, 2024
…rt-2-revert-1-feat/icon-title-patch Revert "Revert "Revert "Revert "Use exe title name""""
JoshuaBrest
pushed a commit
to JoshuaBrest/whisky-wine
that referenced
this pull request
Jul 23, 2024
|
|
||
| // Get offset to the last backslash | ||
| DWORD last_char_pos = 0; | ||
| for (DWORD i = 0; i < len; i++) |
There was a problem hiding this comment.
iterating backward will give the same result without multiple reassignments
| last_char_pos = i; | ||
| } | ||
|
|
||
| if (len && len < ARRAY_SIZE(app_name)) |
There was a problem hiding this comment.
for-loop up above will also fail if this condition is false
possible OOB vulnerability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds functionality to set the application name in the macOS driver. The
macdrv_set_application_namefunction is implemented to set the application name based on the module file name. This allows for better identification of the application in macOS.