Fix no_checksum for EAN13 #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 8, 2024
WhyNotHugo
force-pushed
the
fix-ean-no-checksum
branch
from
fa35e60 to
6f9608a
Compare
The `ean` variable was shadowed early, so a custom 13th digit was lost when ignoring checksums. Fixes: #43
WhyNotHugo
force-pushed
the
fix-ean-no-checksum
branch
from
6f9608a to
14146d2
Compare
|
I tried it and it works very well. |
|
this generates a bar code but the bar code scanner does not work |
|
What do you mean by "does not work"? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
eanvariable was shadowed early, so a custom 13th digit was lost when ignoring checksums.Fixes: #43