Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most invocations of
_convert
are guaranteed to not handle digits in charset C. Handling extra digits in charset C introduces extra complexity due to grouping of pairs of digits, which is handled by_buffer
. (I rename_buffer
to_digit_buffer
for clarity.)In order to isolate the complexity and ease type hinting, I restrict
_convert
to return onlyint
and raise an informative exception whenever the buffer is triggered. Correspondingly I introduce a function_convert_or_buffer
returningint | None
to handle the full case when_digit_buffer
might be used.There is just one single place (
_build
) where_convert_or_buffer
is necessary rather than_convert
.Reasons why
_convert
is safe to use in all other invocations:_new_charset
it's used to switch charset, so it won't be used on a digit._maybe_switch_charset
and_build
it's used to flush the buffer immediately after switching to either charset A or B, so the charset cannot be C._convert_or_buffer
I explicitly check before invoking that the charset isn't C.This makes it clear why only the invocation in
_build
needs to handle theNone
return type. (IMO it's pretty tricky to deduce this if you're not already familiar with the implementation.)