This repository has been archived by the owner on Oct 12, 2024. It is now read-only.
Add permission to silently join/leave servers #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WiIIiam278
suggested changes
Dec 3, 2023
There was a problem hiding this comment.
Nice work; and I'm fine with this implementation. A few things:
- Instead of single-line return statement, I prefer the return; in the guard clauses to be bracket-enclosed on its own line.
- Could we make the permissions a private static final String constant at the top of the class (SILENT_JOIN_PERMISSION, SILENT_LEAVE_PERMISSION)
- Style nit: could you add a space before the open bracket on the condition in the if statements?
added info in config
QarthO
commented
Dec 3, 2023
WiIIiam278
approved these changes
Dec 3, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
join_and_quit_messages.join.enabledis set to true, the server won't send a join message (the ones handled by huskchat) to any players with the permissionhuskchat.silent_joinvice versa for the leave messages.