Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setUserLastPosition to API #368

Merged

Conversation

AlessioDP
Copy link
Contributor

This PR adds setUserLastPosition method to BaseHuskHomesAPI.

I specified Since: 4.2 because I do not know what is the next version.

The method will be used to set user last location on cross-network teleport (Parties#234)

Copy link
Owner

@WiIIiam278 WiIIiam278 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, okay.

I think the reason I didn't expose this by default is since there's an option for listening to the teleport event already which should work with your plugin as is, and I provide a way in the Teleport class to set whether to update this on execution. But I can see the use case here :)

@WiIIiam278 WiIIiam278 added the type: feature request This issue is about a new feature or request label Apr 25, 2023
@AlessioDP
Copy link
Contributor Author

I did not test it yet but I am pretty sure that in Bukkit it would works for teleport/home already. But those commands are executable by Bungeecord/Velocity too and the original server won't get updated.

@WiIIiam278
Copy link
Owner

WiIIiam278 commented Apr 25, 2023

Just note HuskHomes isn't installed on the proxy at all, it's all handled on the backend through platform implementations of dispatching / listening to the plugin message channel

@AlessioDP
Copy link
Contributor Author

No problem, my plugin does the same to dispatch the event to the plugin inside Bukkit so I will be able to call the update position method with the coordinates + original server.

@WiIIiam278 WiIIiam278 merged commit 3828581 into WiIIiam278:master Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature request This issue is about a new feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants