-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wikidata values for catalog providers #428
Conversation
…catalogs Includes a type annotation change: replace Union (more verbose) with Optional
@e-dorigatti : friendly ping |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry for the delay! code is fine but return values need to be made consistent with type annotations. you may look into pre-commit to automatically run type checking, linting, formatting, etc. on commit
Many thanks for the review, your feedback is always super constructive and much appreciated.
Fixed.
Very interesting suggestion! We currently have a similar mechanism in place on Travis CI, see this dotfile.
|
This PR closes #418 .
Please bear in mind that relevant refactoring suggestions from #419 are not yet addressed here: we have opened issues accordingly (#420 #421 #422) and will tackle them as soon as all the new validator features are implemented.