balar-mmio: remove some comments

William-An · Dec 12, 2024 · 8459025 · 8459025
1 parent 6526407
commit 8459025
Show file tree

Hide file tree

Showing 4 changed files with 1 addition and 9 deletions.
diff --git a/src/sst/elements/balar/balarMMIO.cc b/src/sst/elements/balar/balarMMIO.cc
@@ -614,8 +614,7 @@ void BalarMMIO::BalarHandlers::handle(SST::Interfaces::StandardMem::WriteResp* r
                         balar->cuda_ret.cudamemcpy.kind = packet->cuda_memcpy.kind;
                     }
                     break;
-                case GPU_MEMCPY_TO_SYMBOL: 
-                    // TODO: Copy from host to device basically
+                case GPU_MEMCPY_TO_SYMBOL:
                     balar->has_blocked_response = true;
                     if (packet->isSSTmem) {
                         // With SST memory/vanadis, we should sync for it to complete
@@ -932,7 +931,6 @@ void BalarMMIO::BalarHandlers::handle(SST::Interfaces::StandardMem::WriteResp* r
             StandardMem::Write* write = balar->pending_write;
 
             // Call GPGPU-Sim with copied data
-            // TODO: Passed symbol is empty, need to check with Vanadis side
             balar->cuda_ret.cuda_error = cudaMemcpyToSymbol(
                     (const char *) packet->cuda_memcpy_to_symbol.symbol,
                     (const void*) balar->memcpyH2D_dst,

diff --git a/src/sst/elements/balar/tests/testBalar_testsuite_util.py b/src/sst/elements/balar/tests/testBalar_testsuite_util.py
@@ -32,7 +32,6 @@ def initializeTestModule_SingleInstance(class_inst):
 
 ################################################################################
 
-# TODO: Check rodinia's result against reference files for functional correctness
 class BalarTestCase(SSTTestCase):
 
     def initializeClass(self, testName):
@@ -245,8 +244,6 @@ def balar_vanadis_clang_template(self, testcase, testtimeout=600):
 
         # Test cases dispatch dict
         # Tag: [EXE_PATH, DATA_DIR, EXE_args]
-        # TODO Build a function for this? Better way to sort this, like a json?
-        # TODO Should put testcase config in a separate config file and the unittest should just read the file and perform testing?
         testcases = {
             "helloworld": ["./vanadisLLVMRISCV/helloworld", "", ""],
             "vecadd": ["./vanadisLLVMRISCV/vecadd", "", ""],

diff --git a/src/sst/elements/balar/tests/vanadisHandshake/Makefile b/src/sst/elements/balar/tests/vanadisHandshake/Makefile
@@ -2,7 +2,6 @@ PREFIX := $(RISCV_TOOLCHAIN_INSTALL_PATH)/bin/riscv64-unknown-linux-gnu-
 CC     := $(PREFIX)gcc
 CFLAGS := -I. -static -O3
 OBJDUMPFLAGS := -Mno-aliases -Mnumeric --disassemble-all --disassemble-zeroes -S
-# TODO Check RDMA test makefile for the arch and addr_type changing
 ADDR_TYPE ?= uint32_t
 
 all: vanadisHandshake

diff --git a/src/sst/elements/balar/tests/vanadisHandshake/cuda_runtime_api.h b/src/sst/elements/balar/tests/vanadisHandshake/cuda_runtime_api.h
@@ -257,8 +257,6 @@ void __vanadisMapBalar();
 
 unsigned int __cudaRegisterFatBinary(char file_name[256]);
 
-// TODO: How to get the deviceFun name automatically?
-// TODO: Requires parsing the binary?
 void __cudaRegisterFunction(
     uint64_t fatCubinHandle,
     uint64_t hostFun,