Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployctl does not generate clusterhost platform network #437

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

vineela-pachchipulusu
Copy link
Contributor

@vineela-pachchipulusu vineela-pachchipulusu commented Dec 18, 2024

This PR implements the generation of cluster-host type platformNetworks via deployctl without --minimal-config

Test plan:

  • PASS: 'make' and 'make test' ran successfully
  • PASS: deployctl tool generates the cluster-host platformNetworks and addresspools without --minimal-config
  • PASS: deployctl tool doesnot generate the cluster-host platformNetworks and addresspools with --minimal-config

Here attached the generated config by deployctl with deployctl build -s test
config_clusterHost.txt

Test plan:
PASS: 'make' and 'make test' ran successfully

PASS: deployctl tool generates the cluster-host platformNetworks
and addresspools without --minimal-config

PASS: deployctl tool doesnot generate cluster-host platformNetworks
and addresspools with --minimal-config

Signed-off-by: vineela-pachchipulusu <Vineela.Pachchipulusu@windriver.com>
@hugonicodemos
Copy link
Collaborator

Hi @vineela-pachchipulusu , can you test a deployment with the generated config using cluster-host?

@vineela-pachchipulusu
Copy link
Contributor Author

vineela-pachchipulusu commented Dec 18, 2024

Hi @vineela-pachchipulusu , can you test a deployment with the generated config using cluster-host?

Its sucessfull
kubectl get platformNetwork -n deployment
NAME TYPE DYNAMIC INSYNC RECONCILED SCOPE
cluster-host cluster-host true true true bootstrap

@hugonicodemos hugonicodemos requested a review from wasnio December 18, 2024 14:26
@wasnio wasnio merged commit 0b04381 into Wind-River:master Dec 18, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants