error C2099: initializer is not a constant #1208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patricebender
referenced
this pull request
in cap-js/cds-dbs
Jun 27, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [better-sqlite3](https://togithub.com/WiseLibs/better-sqlite3) | [`11.0.0` -> `11.1.1`](https://renovatebot.com/diffs/npm/better-sqlite3/11.0.0/11.1.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>WiseLibs/better-sqlite3 (better-sqlite3)</summary> ### [`v11.1.1`](https://togithub.com/WiseLibs/better-sqlite3/releases/tag/v11.1.1) [Compare Source](https://togithub.com/WiseLibs/better-sqlite3/compare/v11.0.0...v11.1.1) #### What's Changed - Fix macOS x64 builds by [@​m4heshd](https://togithub.com/m4heshd) in [https://github.com/WiseLibs/better-sqlite3/pull/1210](https://togithub.com/WiseLibs/better-sqlite3/pull/1210) - error C2099: initializer is not a constant by [@​LqdBcnAtWork](https://togithub.com/LqdBcnAtWork) in [https://github.com/WiseLibs/better-sqlite3/pull/1208](https://togithub.com/WiseLibs/better-sqlite3/pull/1208) #### New Contributors - [@​LqdBcnAtWork](https://togithub.com/LqdBcnAtWork) made their first contribution in [https://github.com/WiseLibs/better-sqlite3/pull/1208](https://togithub.com/WiseLibs/better-sqlite3/pull/1208) **Full Changelog**: WiseLibs/better-sqlite3@v11.1.0...v11.1.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/cap-js/cds-dbs). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjAuMSIsInVwZGF0ZWRJblZlciI6IjM3LjQyMC4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
|
If you need to patch the vendored-in upstream code, won't this be lost when the next source code import happens? This is also the first time I see the upstream code being directly modified. |
|
I have no idea. I barely understand how to use git. I suppose I could go find sqlite3's source and see if the same issue exists there. But I dunno what that would require. Good call though |
|
@kevinlul this patch is in the upstream code (just not in the currently released version), so we're all good. Here's the commit to trunk: https://www.sqlite.org/src/info/6c103aee6f146869 And here's the discussion: |
mceachen
added a commit
to mceachen/better-sqlite3
that referenced
this pull request
Aug 13, 2024
Merged
JoshuaWise
pushed a commit
that referenced
this pull request
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed the Prebuild on windows 2019 for v11.1.0 was failing.
I believe the issue is caused from the inline multiplication.
Seems like Windows is picky.