Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(database): now nativeBinding supports addon object #974

Merged
merged 8 commits into from
Sep 2, 2023
Merged

feat(database): now nativeBinding supports addon object #974

merged 8 commits into from
Sep 2, 2023

Conversation

destyk
Copy link
Contributor

@destyk destyk commented Mar 28, 2023

If webpack is used to build the application, we must use function __non_webpack_require__ to include third-party files.

This is mentioned here.

@destyk destyk requested a review from JoshuaWise as a code owner March 28, 2023 13:26
lib/database.js Outdated Show resolved Hide resolved
mceachen
mceachen previously approved these changes Apr 19, 2023
Copy link
Member

@mceachen mceachen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@destyk destyk requested a review from a team as a code owner June 19, 2023 08:31
@destyk destyk changed the title Added webpack support feat(database): now nativeBinding supports addon object Jun 19, 2023
@destyk destyk requested a review from mceachen June 19, 2023 08:40
@destyk
Copy link
Contributor Author

destyk commented Jul 26, 2023

@JoshuaWise @mceachen Many users are waiting for merge this PR

@JoshuaWise JoshuaWise merged commit 3400cb0 into WiseLibs:master Sep 2, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants