create test cases and fix typing error #582
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make BpmResultTest.java for test BpmResultTest.java. Make InventoryTest.java for test Inventory.java. Making LoginDataTest.java for test LoginData.java.
Make some test case for .java class into src/me/corriekay/pokegoutil/data/models/.
PokemonCpUtilsTest, PokemonPerformanceCacheTest, PokemonPerformanceStatsTest, PokemonPerformanceTest, PokemonUtilsTest, PokeNickTest ver.1.0.0
pokegoutil.data.managers test
Complete comment for LoginDataTest.java.
PokeGoUtil/src/me/corriekay/pokiutil/data/models/operations
test cases for operation package
PokemonCpUtilsTest, PokemonPerformanceCacheTest, PokemonPerformanceStatsTest, PokemonPerformanceTest, PokemonUtilsTest, PokeNickTest Comment ver.1.0.1
PokemonCpUtilsTest, PokemonPerformanceCacheTest, PokemonPerformanceStatsTest, PokemonPerformanceTest, PokemonUtilsTest, PokeNickTest Comment ver.1.0.3
pokegotuil/utils/pokomon file test
testOracle utils.pokemon
setJSONObject method apply to Introduce Explaining Variable
duplicate return, sIsInit changed in one case only
me.corriekay.pokegoutil.gui.controller package
2. PokemonModel(extracts PokemonCpProvider, PokemonCpOriginalProvider, PokemonCpCurrentProvider) 3. Methods that 2 of getMaxCp~ and 2 of getMaxEvolvedCp~ has almost same code each.
design pattern - strategy pattern
1. Template method pattern
Template method pattern / Manager Package's Initialize
따른 방법 수정시에 해당 함수를 건들지 않도록 하기 위함이다.
Strategy Pattern 적용
managers Package Error correct
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
create many test cases and fix typing error (src/me/corriekay/pokegoutil/data/models/LoginData.java)