-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Mobile] Improve List block onSplit to avoid hiding the keyboard on enter #62446
Conversation
…ustom onSplit and onReplace functionality
Size Change: 0 B Total Size: 1.76 MB ℹ️ View Unchanged
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Flaky tests detected in 2a6c067. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9451758395
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests worked great for me @geriux! 🚀
…nter (WordPress#62446) * Native RichText - Add __unstableUseSplitSelection prop * Native List block - Use __unstableUseSplitSelection prop and remove custom onSplit and onReplace functionality * Update changelog * Fix changelog after fixing conflict Co-authored-by: geriux <geriux@git.wordpress.org> Co-authored-by: twstokes <twstokes@git.wordpress.org> Co-authored-by: fluiddot <carlosgprim@git.wordpress.org>
What?
Fixes #57580
Why?
To avoid hiding and showing the keyboard whenever a new item is added to the list.
How?
In a recent PR #54543 the Web editor unified the split logic of blocks, after some investigation I confirmed using this new functionality solved the issue with the List block.
For now, it only adapts this feature for this block but we should explore enabling this for all blocks as the web editor did.
Testing Instructions
Note
Please use the following builds to test:
Note: Nesting lists make the keyboard hide and show again as the block is recreated.
Testing Instructions for Keyboard
N/A
Screenshots or screencast
iOSListBefore.mov
iOSListAfter.mov