Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mobile] - RichText - Fix undefined onDelete callback #62486

Merged
merged 3 commits into from
Jun 12, 2024
Merged

[Mobile] - RichText - Fix undefined onDelete callback #62486

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c5e466c
Native RichText - Fix undefined onDelete callback
Jun 11, 2024
db9adf7
Update changelog
Jun 11, 2024
b6a38e6
Merge branch 'trunk' into fix/native-rich-text-on-delete
Jun 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/block-editor/src/components/rich-text/native/index.native.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -424,7 +424,9 @@ export class RichText extends Component {
return;
}

onDelete( { isReverse, value } );
if ( onDelete ) {
onDelete( { isReverse, value } );
}

event.preventDefault();
this.lastAztecEventType = 'input';
Expand Down
1 change: 1 addition & 0 deletions packages/react-native-editor/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ For each user feature we should also add a importance categorization label to i
## Unreleased
- [internal] Fix Inserter items list filtering [#62334]
- [*] Prevent hiding the keyboard when creating new list items [#62446]
- [*] RichText - Fix undefined onDelete callback [#62486]

## 1.120.0
- [*] Prevent deleting content when backspacing in the first Paragraph block [#62069]
Expand Down
Loading