Focus Editor Region from Template Footer Click #62595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
jeryj
added
[Type] Bug
|
Size Change: +69 B (0%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
scruffian
force-pushed
the
update/focus-region-from-footer
branch
from
cba31fd to
1b8736b
Compare
scruffian
requested review from
dmsnell,
tellthemachines,
spacedmonkey,
ObliviousHarmony,
t-hamano,
kevin940726,
desrosj,
fluiddot,
dcalhoun,
gziolo,
adamsilverstein,
talldan,
swissspidy,
ajitbohra,
peterwilsoncc,
ntwb,
nerrad,
ryanwelcher,
luisherranz,
DAreRodz,
draganescu and
adamziel
as code owners
scruffian
requested review from
getdave,
atimmer,
ZebulanStanphill,
geriux,
mmtr,
juanmaguitar,
fabiankaegy and
ndiego
as code owners
scruffian
force-pushed
the
try/escape-to-select-parent
branch
from
63d6366 to
cf6cea5
Compare
scruffian
force-pushed
the
update/focus-region-from-footer
branch
from
1b8736b to
944d5f6
Compare
jeryj
force-pushed
the
update/focus-region-from-footer
branch
from
944d5f6 to
6a11f20
Compare
ajlende
approved these changes
Jun 26, 2024
jeryj
force-pushed
the
try/escape-to-select-parent
branch
from
ed018ef to
387ed23
Compare
jeryj
force-pushed
the
update/focus-region-from-footer
branch
from
6a11f20 to
637978a
Compare
ellatrix
reviewed
Jun 28, 2024
| */ | ||
| export default function getEditorRegion( editor ) { | ||
| if ( ! editor ) { | ||
| return null; |
There was a problem hiding this comment.
Note that this could be returning null, but you're calling focus() unconditionally.
There was a problem hiding this comment.
Good catch! Fixed here: #62980
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Clicking the Template button in the footer breadcrumbs causes a focus loss to the body of the page. This PR sets focus to the editor region instead, making it similar to how the other buttons in footer breadcrumbs work.
Why?
a11y. Focus management.
How?
When clicking "Template" in the footer breadcrumbs, set focus on the editor canvas region through a new utility, getEditorRegion.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast