-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WP 6.6 merge for 63118] Make SiteHub available for Pages, Patterns, and Templates in mobile viewports #63156
Conversation
…iewports (#63118) * Create a SiteHubMobile only available for Pages, Patterns, and Templates * Fix spacing issues Co-authored-by: oandregal <oandregal@git.wordpress.org> Co-authored-by: MaggieCabrera <onemaggie@git.wordpress.org> Co-authored-by: andrewserong <andrewserong@git.wordpress.org> Co-authored-by: jameskoster <jameskoster@git.wordpress.org> Co-authored-by: ramonjd <ramonopoly@git.wordpress.org> Co-authored-by: aaronrobertshaw <aaronrobertshaw@git.wordpress.org> Co-authored-by: annezazu <annezazu@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked again the commit in #63118
Also checked in device
Kapture.2024-07-05.at.10.23.30.mp4
Thank you!
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Size Change: +175 B (+0.01%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
What?
This PR merged the changes from #63118 into the WP 6.6 branch: Add the SiteHub to the mobile view of Pages, Patterns, and Templates in the site editor.
Why?
There was a merge conflict in
layout/index.js
, so this change needed a separate PR in order to merge.How?
Cherry pick as in the comment: #63118 (comment)
Testing Instructions
Follow the testing instructions in #63118. Broadly:
Navigate to Pages, Patterns, and Templates and verify the SiteHub is present and that it navigates back. The SiteHub in the other pages (root, Styles, Navigation) takes you to the wp-admin instead.