WP 6.6 merge - Patterns: check for edited entity content property when exporting #63277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge #63227 into wp/6.6
ramonjd
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ramonjd
commented
Jul 9, 2024
| content: item.patternPost.content.raw, | ||
| syncStatus: item.patternPost.wp_pattern_sync_status, | ||
| content: item?.patternPost?.content?.raw || item.content, | ||
| syncStatus: |
There was a problem hiding this comment.
Thanks to @t-hamano for the tip about migrating syncStatus as well 👍🏻
|
Size Change: +10 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
andrewserong
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR merges #63227 into wp/6.6
It ensures that
contentandsyncStatusis exported when exporting custom patterns from the editor pattern side bar.Why?
The "item" passed to getJsonFromItem is fetched using getEditedEntityRecord.
getEditedEntityRecordcalls getRawEntityRecord.getRawEntityRecordmaps properties to their raw values, socontent.rawwill be mapped tocontent.Because an item can either be an entity record fetched via
getEntityRecordorgetEditedEntityRecord, I think we should support both formats.How?
Checks for
content.rawandcontentwhen exporting item JSON, e.g., for a custom pattern.Testing Instructions
syncStatus,title.Example:
{ "__file": "wp_block", "title": "Test Custom Pattern (Copy)", "content": "<!-- wp:paragraph -->\n<p>A synced pattern</p>\n<!-- /wp:paragraph -->", "syncStatus": "unsynced" }Kapture.2024-07-08.at.17.25.20.mp4