PaletteEdit: Add appropriate size props to Buttons #66590
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -215,6 +215,7 @@ function Option< T extends PaletteElement >( { | |||||
| <Item ref={ setPopoverAnchor } size="small"> | ||||||
| <HStack justify="flex-start"> | ||||||
| <Button | ||||||
| size="small" | ||||||
| onClick={ () => { | ||||||
| setIsEditingColor( true ); | ||||||
| } } | ||||||
|
|
@@ -501,6 +502,7 @@ export function PaletteEdit( { | |||||
| <NavigableMenu role="menu"> | ||||||
| { ! isEditing && ( | ||||||
| <Button | ||||||
| __next40pxDefaultSize | ||||||
| variant="tertiary" | ||||||
| onClick={ () => { | ||||||
| setIsEditing( true ); | ||||||
|
|
@@ -513,6 +515,7 @@ export function PaletteEdit( { | |||||
| ) } | ||||||
| { ! canOnlyChangeValues && ( | ||||||
| <Button | ||||||
| __next40pxDefaultSize | ||||||
| variant="tertiary" | ||||||
| onClick={ () => { | ||||||
| setEditingElement( | ||||||
|
|
@@ -535,6 +538,8 @@ export function PaletteEdit( { | |||||
| ) } | ||||||
| { canReset && ( | ||||||
| <Button | ||||||
| __next40pxDefaultSize | ||||||
| className="components-palette-edit__menu-button" | ||||||
|
Comment on lines
+541
to
+542
There was a problem hiding this comment. The last menu item is visible when the
There was a problem hiding this comment. Classname addition makes sense to resolve this. I just wonder if these buttons make sense to be menu items instead of buttons? Not something to block the PR of course. There was a problem hiding this comment. Right, it looks like this could be a DropdownMenu. @ciampo Should we add any new dropdown instances using DropdownMenuV2, or should we still use v1 until it's a bit more stable? There was a problem hiding this comment. Let's keep v1 for now, but use this as a place where we can use v2 soon (probably as soon as #66383 is merged) |
||||||
| variant="tertiary" | ||||||
| onClick={ () => { | ||||||
| setEditingElement( | ||||||
|
|
||||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't tell if there's any intentionality to the height of these rows. @WordPress/gutenberg-design Is the natural height resulting from this fix acceptable, or do we want to maintain a certain row height?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This predates my involvement so I can't comment with confidence on the intentionality. Aiming for
40pxrows seems acceptable to me though.This whole UI likely needs to be revisited and standardised at some point.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, let's leave it like this for now until we have time to revisit.