Update since command for standalone plugin usage
#1119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
thelovekesh
added
[Type] Enhancement
felixarntz
reviewed
Apr 9, 2024
There was a problem hiding this comment.
Thank you for the PR @thelovekesh, this looks great!
Just a few minor points of feedback.
felixarntz
reviewed
Apr 9, 2024
Co-authored-by: Felix Arntz <felixarntz@users.noreply.github.com>
Co-authored-by: Felix Arntz <felixarntz@users.noreply.github.com>
Co-authored-by: Felix Arntz <felixarntz@users.noreply.github.com>
felixarntz
approved these changes
Apr 9, 2024
westonruter
reviewed
Apr 10, 2024
thelovekesh
commented
Apr 10, 2024
| @@ -17,7 +22,7 @@ const catchException = ( handler ) => { | |||
| try { | |||
| await handler( ...args ); | |||
| } catch ( error ) { | |||
| console.error( error ); // eslint-disable-line no-console | |||
| console.error( formats.error( error.message ) ); // eslint-disable-line no-console | |||
felixarntz
approved these changes
Apr 10, 2024
There was a problem hiding this comment.
Thanks @thelovekesh @westonruter, current code looks great!
westonruter
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1118
Relevant technical choices
--pluginflag to pass the specific plugin name.--pluginflag is passed, it will run on PL plugin.--pluginis passed with wrong plugin name.