Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimization Detective: Update build command #1454

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

mukeshpanchal27
Copy link
Member

Summary

This PR solve the fatal error:

PHP Fatal error:  [Optimization Detective] Unable to load build/web-vitals.asset.php. 
Please make sure you have run `npm install && npm run build:optimization-detective`. in /var/www/html/wp-content/plugins/optimization-detective/load.php on line 81

The error suggests running npm run build:optimization-detective to build the plugin assets, but the correct command is npm run build:plugin:optimization-detective.

@mukeshpanchal27 mukeshpanchal27 added [Type] Documentation Documentation to be added or enhanced [Plugin] Optimization Detective Issues for the Optimization Detective plugin labels Aug 9, 2024
@mukeshpanchal27 mukeshpanchal27 self-assigned this Aug 9, 2024
@mukeshpanchal27 mukeshpanchal27 marked this pull request as ready for review August 9, 2024 05:07
Copy link

github-actions bot commented Aug 9, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: mukeshpanchal27 <mukesh27@git.wordpress.org>
Co-authored-by: westonruter <westonruter@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@westonruter westonruter merged commit 9e03810 into trunk Aug 9, 2024
21 checks passed
@westonruter westonruter deleted the update/od-build-command branch August 9, 2024 06:15
@westonruter westonruter added the skip changelog PRs that should not be mentioned in changelogs label Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Plugin] Optimization Detective Issues for the Optimization Detective plugin skip changelog PRs that should not be mentioned in changelogs [Type] Documentation Documentation to be added or enhanced
Projects
Status: Done 😃
Development

Successfully merging this pull request may close these issues.

2 participants