-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
App shell #19
Conversation
d702a30
to
90eea26
Compare
Looks very promising already! Some observations: we reload the playground iframe as a whole, I think'd be better if we keep the iframe around in the wp-admin tab and the preview iframe is one that links to the right Also we should show the preview section below the app section if the sidebar is not wide enough. |
Opened #21 to track this.
Opened #22.
Agree, I will do so in the next PR. |
This PR sets up the "scaffolding" for the reimagined extension, as discussed between myself and @akirk. The extension is now structured so that there's an
App
(where our code lives), with Playground running next to it. This PR only sets up the basic foundations, it does not do anything useful yet.Some considerations:
react-router
, which in essence maps URLs to componentsreact-router
is widely used in React projectsScreen captures
Note that Playground only re-renders when the session changes, which is what we want. That's not visible in this recording because there are currently no other pages to transition to, but I've tested this with a dummy page and can confirm Playground does not re-render when transitioning between pages in the same session.
Screen.Recording.2024-08-30.at.19.21.20.mov
The data in local storage looks like this: