Skip to content

Commit

Permalink
chore: Removal of InputIconContainer (#2838)
Browse files Browse the repository at this point in the history
Fixes: #2501  

Removed `InputIconContainer` because it doesn't handle bidirectionality or icons at the start of an input. Please use [`InputGroup`](https://workday.github.io/canvas-kit/?path=/docs/components-inputs-text-input--icons) from Main.

[category:Components]

Release Note:
We've removed `InputIconContainer` from Main. Please use [`InputGroup`](https://workday.github.io/canvas-kit/?path=/docs/components-inputs-text-input--icons) from Main instead.
  • Loading branch information
josh-bagwell authored Jul 23, 2024
1 parent 034a9c4 commit bbd7343
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 57 deletions.
9 changes: 8 additions & 1 deletion modules/docs/mdx/12.0-UPGRADE-GUIDE.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ A note to the reader:
- [Codemod](#codemod)
- [Deprecations](#deprecations)
- [Removals](#removals)
- [InputIconContainer](#inputiconcontainer)
- [Select (Preview)](#select-preview)
- [Component Updates](#component-updates)
- [Popup, Dialog and Modal](#popup-dialog-and-modal)
Expand Down Expand Up @@ -75,7 +76,13 @@ Removals are deletions from our codebase and you can no longer consume this comp

**PR:** [#2796](https://github.com/Workday/canvas-kit/pull/2796)

We've removed the `Select` component that was in Preview. Please use the compound [`Select` component from Main](https://workday.github.io/canvas-kit/?path=/docs/components-inputs-select--basic).
We've removed the `Select` component that was in Preview. Please use the compound [Select component from Main](https://workday.github.io/canvas-kit/?path=/docs/components-inputs-select--basic).

### InputIconContainer

**PR:** [#2838](https://github.com/Workday/canvas-kit/pull/2838)

We've removed `InputIconContainer` from Main. Please use [InputGroup](https://workday.github.io/canvas-kit/?path=/docs/components-inputs-text-input--icons) from Main instead.

---

Expand Down
1 change: 0 additions & 1 deletion modules/react/text-input/index.ts
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
export * from './lib/InputIconContainer';
export * from './lib/TextInput';
export {InputGroup, useInputGroupModel} from './lib/InputGroup';
39 changes: 0 additions & 39 deletions modules/react/text-input/lib/InputIconContainer.tsx

This file was deleted.

16 changes: 0 additions & 16 deletions modules/react/text-input/spec/InputIconContainer.spec.tsx

This file was deleted.

0 comments on commit bbd7343

Please sign in to comment.