develop MergeListTag filter #28
Merged
+125
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related to #10 |
eiennohito
reviewed
Nov 16, 2023
|
|
||
| if (isAccteptedTags && paragraph.path == nextParagraph.path) { | ||
| val mergedParagraph = nextParagraph.copy( | ||
| text = List(paragraph.text, nextParagraph.text) |
There was a problem hiding this comment.
This line will have O(n^2) complexity because strings are immutable in Java. Should not still cause much problems I think.
There was a problem hiding this comment.
If I can afford to change this line after completing various tasks, I refactor it.
There was a problem hiding this comment.
I think we are OK with leaving it as is because
- Lists should not be very large
- Individual strings are not 1 character long
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add MergeListTag into filters.
This filter merges consecutive paragraphs including the
liandoptiontag.When scanning a paragraph list and there are adjacent paragraphs containing li / option tags, merge them into the paragraph on the right and add a remove sign to the paragraph on the left.