Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip ui for search bar, no functionality #662

Closed
wants to merge 1 commit into from

Conversation

cyriun
Copy link
Contributor

@cyriun cyriun commented Oct 15, 2023

No description provided.

@rdw-software
Copy link
Member

It seems there is a template for search boxes that could be reused:

I haven't looked into how it works exactly, but the search functionality itself should be doable as well.

As far as I can tell, the group table here could be filtered to remove all entries that don't match the given search term. Implementing a filter shouldn't be too difficult once the actual location in the code where it should be applied has been identified:

  • For simplicity's sake, assume we're only filtering the (localized) item name
  • Use Lua's string pattern matching capabilities to check if item.name is a match
  • If not, remove the item from the table (only the GUI display group, not the actual database/saved variables of course)

Maybe that helps with the rest of this PR? :) Thanks for starting on this task.

@rdw-software
Copy link
Member

It doesn't seem like there's anyone who currently has the bandwidth to design and implement this feature.

I'll close the PR until that changes. We can use the above as a starting point if/when the issue is revisited :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add search box to filter the lists in the options menu and make finding specific items easier
2 participants