Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup and upgrade dependencies to fix various CVEs #159

Merged
merged 1 commit into from
Sep 22, 2023

Conversation

pavelhoral
Copy link
Member

@pavelhoral pavelhoral commented Sep 21, 2023

This PR fixes issues with incorrect dependencies being on classpath. Ideally this should have been done before releasing RC1, but well... here we are.

I have reviewed all dependencies in the top-level POM, ordered them alphabetically and marked few of them as deprecated. Everything seems to be working... major changes are:

  • most dependencies are at their newest versions
  • Javax artifacts were switched to Jakarta artifacts (getting ready to switch to Jakarta packages :))
    • This was done in Wren:AM before a similar change had been done in Wrensec Commons, so a similar activity needs to be done there as well. There is a dedicated section in parent POM to exclude transitive Javax stuff from Wrensec Commons.
  • introduced monkey patch for JAXB1 binary incompatibility regarding com.sun.xml.bind.Messages class
    • I did try to migrate that to JAXB2 but that is unfortunately not possible without major rewrite.
  • commented out few unnecessary dependencies (will be removed in the future)

There are still few steps that should be considered after merging this PR:

  • potentially uploading Restlet JARs to JFrog as they are currently unsigned
  • go through various XXX/TODO/FIXMEs inside pom.xml files
    • check whether marked configuration is still needed (mainly talking about transitive exlusions)
    • upgrade maven plugin versions
  • perform at least a simple smoke tests for SAML features (this is one area I have not covered)

Copy link
Member

@karelmaxa karelmaxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great job.

@karelmaxa karelmaxa merged commit 1241155 into WrenSecurity:main Sep 22, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants