fix es-build angular 16 'Cannot assign to import "baseApiUrl"' #408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixing es-build angular 16 build with error
```
Cannot assign to import "baseApiUrl"
node_modules/ngx-mapbox-gl/fesm2022/ngx-mapbox-gl.mjs:34:25:
34 │ MapboxGl.baseApiUrl = options.customMapboxApiUrl;
╵ ~~~~~~~~~~
Imports are immutable in JavaScript. To modify the value of this import
```
related to evanw/esbuild#891,
fixes:
Wykks#403
Wykks#407
Anakii
approved these changes
Oct 17, 2023
|
Hey, do you have any news for this PR ? I really need this fix 😬 @Wykks |
|
Hi, I should have looked into this before, LTGM :) |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 0c38932. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution
✅ Successfully ran 3 targetsSent with 💌 from NxCloud. |
|
Hi ! Will there be a new release soon? I still can't use esbuild because of this package... |
|
@Wykks can you release this fix? The pipeline failed so it was never released. |
|
@Wykks Could you release this fix please ? 🙏 |
|
@Wykks is this dead? We can update the package directly, but it will be flaky for deployments. Thanks for the work too! |
denisyilmaz
pushed a commit
to denisyilmaz/ngx-mapbox-gl
that referenced
this pull request
Sep 10, 2024
fixing es-build angular 16 build with error
```
Cannot assign to import "baseApiUrl"
node_modules/ngx-mapbox-gl/fesm2022/ngx-mapbox-gl.mjs:34:25:
34 │ MapboxGl.baseApiUrl = options.customMapboxApiUrl;
╵ ~~~~~~~~~~
Imports are immutable in JavaScript. To modify the value of this import
```
related to evanw/esbuild#891,
fixes:
Wykks#403
Wykks#407
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixing es-build angular 16 build with error
related to evanw/esbuild#891, maplibre/maplibre-gl-js#1550
fixes:
#403
#407