Docker #136
Open
Docker #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While we can't update the runtime files are part of our docker containers, nothing prevents someone from using a java container with Wylx mounted and updating that mounted volume
joshuamb419
requested changes
Sep 21, 2024
There was a problem hiding this comment.
I know WylxEnvConfig.java is currently just the .env files but I strongly feel that this belongs in there setting a variable instead of being a method that is called any time we check if Wylx is running in docker. Its not like thats going to change mid run, its an env variable and as such should be in the same file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No automated action to create or upload these yet. Will do in a separate PR.