Skip to content

Commit

Permalink
feat: support node-v20.x
Browse files Browse the repository at this point in the history
PR-URL: #224
  • Loading branch information
hyj1991 authored Apr 22, 2023
1 parent ef2f63e commit 47d814f
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 6 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/nodejs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
{os: "macos-latest", arch: "x64"},
{os: "ubuntu-latest", arch: "x64"},
]
node-version: [ 12, 14, 16, 18, 19 ]
node-version: [ 12, 14, 16, 18, 20 ]
steps:
- name: Checkout Git Source
uses: actions/checkout@master
Expand Down
8 changes: 4 additions & 4 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -55,20 +55,20 @@
},
"homepage": "https://github.com/X-Profiler/xprofiler#readme",
"dependencies": {
"@xprofiler/node-pre-gyp": "^1.0.9",
"@xprofiler/node-pre-gyp": "^1.0.10",
"moment": "^2.29.4",
"nan": "^2.17.0",
"uuid": "^9.0.0",
"yargs": "^17.6.2"
"yargs": "^17.7.1"
},
"devDependencies": {
"@istanbuljs/schema": "^0.1.3",
"autod": "^3.1.2",
"clang-format": "^1.8.0",
"codecov": "^3.8.3",
"eslint": "^8.31.0",
"eslint": "^8.38.0",
"expect.js": "^0.3.1",
"mm": "^3.2.1",
"mm": "^3.2.2",
"mocha": "^10.2.0",
"nyc": "^15.1.0"
},
Expand Down
1 change: 1 addition & 0 deletions scripts/versions.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,5 @@ exports.os7u = [
exports.os8u = [
'node-v18.13.0',
'node-v19.4.0',
'node-v20.0.0',
];
2 changes: 1 addition & 1 deletion src/hooks/fatal_error.cc
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ void DumpBeforeAbort(const char* location, const char* message) {
EnvironmentData* env_data = EnvironmentData::GetCurrent(isolate);
ThreadId thread_id = env_data->thread_id();

#ifndef _WIN32
#if (defined(__APPLE__) || (defined(__linux__) && defined(__x86_64__)))
// finish sampling
FinishSampling(isolate, "fatal_error");
#endif
Expand Down

0 comments on commit 47d814f

Please sign in to comment.