Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3 Add release notes for PlayStore/ApkPure/iOS #10

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

timobaehr
Copy link

@timobaehr timobaehr commented Jan 10, 2023

Add release notes for iOS

For iOS, the release notes can be queried in a simple way.

Add release notes for ApkPure

ApkPure is HTML and release notes must be extracted via regular expression.

Google Play status

Google Play is HTML and release notes must be extracted via regular expression.

Refactoring

  • At the moment, all the code of the library is in a single file. In the context of this pull request, a file was created for each subject (class/entity). I also added Api where PlayStoreApi, AppleStoreApi and ApkPureApi implements Api.
  • AppCheckerResult used positional arguments. I changed this to named arguments as it is likely that you swap the string arguments.
  • Tests was missing. This makes a lot of sense for working on HTML with regular expressions.

@timobaehr timobaehr changed the title Add release notes for iOS #3 Add release notes for iOS Jan 10, 2023
@timobaehr timobaehr changed the title #3 Add release notes for iOS #3 Add release notes for iOS/ApkPure Jan 11, 2023
@timobaehr timobaehr mentioned this pull request Jan 12, 2023
@timobaehr timobaehr changed the title #3 Add release notes for iOS/ApkPure #3 Add release notes for PlayStore/ApkPure/iOS Apr 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant