Skip to content
This repository has been archived by the owner on Jun 5, 2024. It is now read-only.

Move all simulation contexts to WFSim #430

Merged
merged 5 commits into from
Jan 16, 2024
Merged

Move all simulation contexts to WFSim #430

merged 5 commits into from
Jan 16, 2024

Conversation

dachengx
Copy link
Contributor

@dachengx dachengx commented Jan 15, 2024

What is the problem / what does the code in this PR do

Together with XENONnT/straxen#1320, to disentangle straxen and wfsim, and make the software environment easier. Because we do not need to maintain compatibility of wfsim inside both wfsim and straxen, e.g. the nestpy(needed by wfsim) currently does not support py3.11(NESTCollaboration/nestpy#104), so we can not update straxen to support py3.11, which is not reasonable.

WFSim needs you:

  • Please add a test for this PR, as a bare minimum, make sure it's covered in coveralls!
  • Can you add a docsting to all your functions?

Pay attention:

  • Due to databases being needed for testing, making a PR from your own fork will typically NOT run the tests. If you then merge master might break

Copy link
Collaborator

@ramirezdiego ramirezdiego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @dachengx. Let's wait for the pypi release fixes to merge.

@ramirezdiego ramirezdiego marked this pull request as ready for review January 16, 2024 12:22
@coveralls
Copy link

coveralls commented Jan 16, 2024

Coverage Status

coverage: 82.718% (+0.1%) from 82.605%
when pulling 3352318 on move_sim_context
into 580ca10 on master.

@dachengx dachengx merged commit 208a0ee into master Jan 16, 2024
6 checks passed
@dachengx dachengx deleted the move_sim_context branch January 16, 2024 15:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants