Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source-wise interpolation #228

Merged
merged 5 commits into from
Nov 13, 2024
Merged

Source-wise interpolation #228

merged 5 commits into from
Nov 13, 2024

Conversation

hammannr
Copy link
Collaborator

Enables (and defaults to) source-wise interpolation, which is introduced in blueice PR46.

Let's wait with this PR until the blueice PR is done but I'll put this here in case anyone wants to already give it a try!

Base automatically changed from fix_livetime_in_expectation to main October 11, 2024 13:38
@coveralls
Copy link

coveralls commented Oct 14, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11387462557

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.04%) to 89.695%
Files with Coverage Reduction New Missed Lines %
alea/parameters.py 1 90.91%
Totals Coverage Status
Change from base Build 11387444673: -0.04%
Covered Lines: 1706
Relevant Lines: 1902
💛 - Coveralls

@hammannr hammannr marked this pull request as ready for review November 8, 2024 14:50
@hammannr hammannr requested review from dachengx and kdund November 8, 2024 14:50
kdund
kdund approved these changes Nov 8, 2024
View reviewed changes
Copy link
Collaborator

@kdund kdund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test pass, minimal changes-- thank you, @hammannr !

@hammannr hammannr merged commit 7029e63 into main Nov 13, 2024
6 of 7 checks passed
@hammannr hammannr deleted the source_wise_interpolation branch November 13, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdund kdund kdund approved these changes

@dachengx dachengx Awaiting requested review from dachengx

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hammannr @coveralls @kdund