Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set required_parameter as method of Config #119

Merged
merged 1 commit into from
Nov 14, 2023
Merged

Conversation

dachengx
Copy link
Collaborator

@dachengx dachengx commented Nov 14, 2023

When calling Component.deduce at

if config.required_parameter is not None:
, the llh_name of config is not specified(it will be specified at Component.compile, where config.llh_name will be called). So for SigmaMap.required_parameter, we have to specify Component.llh_name as an argument to search for the map for llh_name.

This is a further fix of #116.

Copy link

github-actions bot commented Nov 14, 2023

Pull Request Test Coverage Report for Build 6867209184

  • 26 of 29 (89.66%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 83.953%

Changes Missing Coverage Covered Lines Changed/Added Lines %
appletree/config.py 23 26 88.46%
Totals Coverage Status
Change from base Build 6855204918: -0.02%
Covered Lines: 1941
Relevant Lines: 2312

💛 - Coveralls

@dachengx dachengx requested a review from zihaoxu98 November 14, 2023 17:25
@dachengx dachengx marked this pull request as ready for review November 14, 2023 17:25
@dachengx dachengx merged commit ebb6cdd into master Nov 14, 2023
7 checks passed
@dachengx dachengx deleted the fix_again_sigmamap branch November 14, 2023 17:57
@dachengx dachengx added the bug Something isn't working label Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant