-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Debug when bins_type
is not set
#153
Conversation
Pull Request Test Coverage Report for Build 8315093996Details
💛 - Coveralls |
@@ -552,7 +554,7 @@ def new_component(self, llh_name: Optional[str] = None, pass_binning: bool = Tru | |||
name=self.name + "_copy", | |||
llh_name=llh_name, | |||
bins=self.bins, | |||
bins_type=self.bins, | |||
bins_type=self.bins_type, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A bug that we never captured.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for capturing this!
@@ -552,7 +554,7 @@ def new_component(self, llh_name: Optional[str] = None, pass_binning: bool = Tru | |||
name=self.name + "_copy", | |||
llh_name=llh_name, | |||
bins=self.bins, | |||
bins_type=self.bins, | |||
bins_type=self.bins_type, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for capturing this!
Fix a bug when
bins_type
is not set. If so https://github.com/XENONnT/appletree/pull/153/files#diff-1667dab9dcf0c2d37d4f00474c771b8eca0c098251dbfe9e0a64405656e00966L56 will raiseAttributeError
.