Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix backend filename if the user changes the h5 filename #185

Merged
merged 3 commits into from
Sep 4, 2024

Conversation

zihaoxu98
Copy link
Collaborator

@zihaoxu98 zihaoxu98 commented Sep 4, 2024

If someone initialize the context by appletree.Context.from_backend(file_name), the backend_h5 will be from the instruct stored in the backend file, not the file name of the backend. It's buggy if someone changes the backend file name after a fitting. This PR forces the backend_h5 to be the correct file name

@coveralls
Copy link

coveralls commented Sep 4, 2024

Pull Request Test Coverage Report for Build 10707213964

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.006%) to 85.196%

Totals Coverage Status
Change from base Build 10707206869: 0.006%
Covered Lines: 2440
Relevant Lines: 2864

💛 - Coveralls

@zihaoxu98 zihaoxu98 requested a review from dachengx September 4, 2024 17:36
@dachengx dachengx merged commit 2854878 into master Sep 4, 2024
7 checks passed
@dachengx dachengx deleted the fix_backend branch September 4, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants