Fix cut acceptance plotting #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 6, 2024 15:30
ghusheng
commented
May 7, 2024
saltax/match/utils.py
Outdated
| for cut_oi in all_cut_list: | ||
| selected_events_cut_oi = selected_events[apply_single_cut(selected_events, cut_oi)] | ||
| selected_events_cut_oi = selected_events[cut_func(selected_events, cut_oi)] | ||
| # Efficiency curves with Clopper-Pearson uncertainty estimation | ||
| interval = binomtest(len(selected_events_cut_oi), len(selected_events)).proportion_ci() | ||
| result_dict[cut_oi][i] = len(selected_events_cut_oi) / len(selected_events) |
There was a problem hiding this comment.
Hi Lanqing! If we still keep the code like this, I am not sure the N-1 cut acceptance is correct. should be len(selected_events_all_cut) / len(selected_events_cut_oi)?
There was a problem hiding this comment.
Great thanks for the sanity check now I wake up. Is it better now?
There was a problem hiding this comment.
Haha, the thing is that if you change in this way then it won't work for the single cut acceptance. These two need to be treated differently :)
There was a problem hiding this comment.
You are right. I buy it. Let me revert.
for more information, see https://pre-commit.ci
np |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the
n_minus_1 plottingoption in theget_cut_eff