-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
G4 fuse input #147
Draft
FaroutYLq
wants to merge
6
commits into
main
Choose a base branch
from
g4_fuse_input
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+117
−43
Draft
G4 fuse input #147
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
be872f7
Enable AmBe generator to read from fuse type input
1f89e44
some improvements on that
2f8e8e3
Merge branch 'main' of https://github.com/XENONnT/saltax into g4_fuse…
0e574c4
remove geant4_interactions dtype
f5e7d0b
ship with last config
af141e8
Clean up a bit
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is where things are suspicious. How does the output records chunk look like? Are the chunks crazily huge? @jjakob03
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice if you can direct me to where your records/raw_records_simu is
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed this because fuse did drop it as well in this PR. Do you think we need it here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Honestly I am not sure if it is necessary and removing it will break things. I am just a bit nervous since this is chunk related, and chunk size does matter hugely for memory consumption. I see that your memory requested is already 55GB. I would say 70GB is the maximum we can take. Maybe give it a last try with 70GB?
Also I would want to see the raw_records_simu and records files. Is it somewhere on midway?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No sorry I keep them in my scratch. records chunk size is ~1.2GB each with 72 chunks in total and, raw_records_simu chunk size is ~300MB and also 72 chunks in total. Is that helpful?
Yes I would have already gone for more memory but broadwl won't give me more than 58GB and xenon1t partition can't see project and midway3/scratch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No sorry I keep them in my scratch. records chunk size is ~1.2GB each with 72 chunks in total and, raw_records_simu chunk size is ~300MB and also 72 chunks in total. Is that helpful?
This is helpful. Maybe try
lgrandi
on midway3. Note that you will have to reinstall things... which gonna be a painful 5 minutesThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the info you gave I don't think this is where things break. Maybe it is just the AmBe super heavy nature itself + some memory leakage. We never figured out why peak building is so expensive in memory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By the way, it worked with 65GB on lgrandi. Also, I wasn't aware that the one run I tested with is a 20min AmBe run from topCW5d9m position, while the topCW7d8m ones are only 10 minutes. So probably this is really just super heavy AmBe 😐
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks I think it makes a lot of sense to me! Yeah this is how difficult things are for AmBe computing..