Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Viewer and basic matching #70

Merged
merged 11 commits into from
Dec 18, 2023
Merged

Viewer and basic matching #70

merged 11 commits into from
Dec 18, 2023

Conversation

FaroutYLq
Copy link
Collaborator

Before you submit this PR: make sure to put all operations-related information in a wiki-note, a PR should be about code and is publicly accessible

What does the code in this PR do / what does it improve?

Implemented basic matching algorithm and waveform viewer.

Can you briefly describe how it works?

For matching:

  • Filtering out bad truth in simulation
    • Missing S1 or S2
    • Reconstructed multiple S1 and S2 from one truth
    • "found" both S1 and S2. (Currently turned off this criteria because of a bug in wfsim leading to shifted timing)
  • Match simulation to the filtered truth
  • Match the saltax events to the matched simulation
  • Match those matched simulation to saltax events again.

You end up with equal length arrays events_salt_matched_to_simu and events_simu_matched_to_salt.

Can you give a minimal working example (or illustrate with a figure)?

Please include the following if applicable:

  • Add an appropriate tag to this PR
  • Update the docstring(s)
  • Update the documentation
  • Tests to check the (new) code is working as desired.
  • Does it solve one of the open issues on github?

Notes on testing

  • Until the automated tests pass, please mark the PR as a draft.
  • On the XENONnT fork we test with database access, on private forks there is no database access for security considerations.

All italic comments can be removed from this template.

@FaroutYLq FaroutYLq added the enhancement New feature or request label Dec 18, 2023
@FaroutYLq FaroutYLq self-assigned this Dec 18, 2023
@FaroutYLq FaroutYLq merged commit 3ee593c into main Dec 18, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant