Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match s1 only #75

Merged
merged 3 commits into from
Dec 20, 2023
Merged

Match s1 only #75

merged 3 commits into from
Dec 20, 2023

Conversation

FaroutYLq
Copy link
Collaborator

Before you submit this PR: make sure to put all operations-related information in a wiki-note, a PR should be about code and is publicly accessible

What does the code in this PR do / what does it improve?

  • Using PEMA matching in selection, but requiring S1 only.
  • Added example notebook

Can you briefly describe how it works?

Requiring S1 to be found by pema.

Can you give a minimal working example (or illustrate with a figure)?

Please include the following if applicable:

  • Add an appropriate tag to this PR
  • Update the docstring(s)
  • Update the documentation
  • Tests to check the (new) code is working as desired.
  • Does it solve one of the open issues on github?

Notes on testing

  • Until the automated tests pass, please mark the PR as a draft.
  • On the XENONnT fork we test with database access, on private forks there is no database access for security considerations.

All italic comments can be removed from this template.

@FaroutYLq FaroutYLq added the enhancement New feature or request label Dec 20, 2023
@FaroutYLq FaroutYLq self-assigned this Dec 20, 2023
@FaroutYLq FaroutYLq merged commit 42fc818 into main Dec 20, 2023
@FaroutYLq FaroutYLq deleted the match_s1_only branch April 1, 2024 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant