Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add S1 pattern likelihood for alt S1 #1323

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Add S1 pattern likelihood for alt S1 #1323

wants to merge 6 commits into from

Conversation

zihaoxu98
Copy link
Contributor

@zihaoxu98 zihaoxu98 commented Jan 16, 2024

What does the code in this PR do / what does it improve?

This PR adds new fields of S1 pattern likelihoods for alt S1, which are "alt_s1_2llh", "alt_s1_top_2llh", "alt_s1_bottom_2llh". They could be useful for s1 single scatter cut.

Can you briefly describe how it works?

For alt S1's calculation, most of the changes are just with a prefix "alt_". The only exception is z, with prefix "alt_s1_".

Can you give a minimal working example (or illustrate with a figure)?

Same as before

Please include the following if applicable:

  • Update the docstring(s)
  • Update the documentation
  • Tests to check the (new) code is working as desired.
  • Does it solve one of the open issues on github?

@coveralls
Copy link

coveralls commented Jan 16, 2024

Coverage Status

coverage: 89.489% (+0.03%) from 89.463%
when pulling 8077155 on alt_s1_llh
into 9813b30 on master.

@zihaoxu98 zihaoxu98 marked this pull request as ready for review January 16, 2024 22:21
@zihaoxu98 zihaoxu98 requested a review from dachengx January 16, 2024 22:21
@GiovanniVolta
Copy link
Contributor

May I suggest @minzhong98 as a reviewer for this PR? He is an expert on the S1 PL cut

@zihaoxu98 zihaoxu98 requested a review from minzhong98 January 29, 2024 12:56
@minzhong98
Copy link

This PR looks good to me, thanks @zihaoxu98 !

@dachengx
Copy link
Collaborator

dachengx commented Jan 29, 2024

I think we still need to discuss whether we need this nice PR and more importantly the cut depends on it. So I would hesitate a bit about when to merge this.

@zihaoxu98
Copy link
Contributor Author

I agree. No rush on merging this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants