-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add S1 pattern likelihood for alt S1 #1323
Open
zihaoxu98
wants to merge
6
commits into
master
Choose a base branch
from
alt_s1_llh
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
May I suggest @minzhong98 as a reviewer for this PR? He is an expert on the S1 PL cut |
This PR looks good to me, thanks @zihaoxu98 ! |
minzhong98
approved these changes
Jan 29, 2024
I think we still need to discuss whether we need this nice PR and more importantly the cut depends on it. So I would hesitate a bit about when to merge this. |
I agree. No rush on merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the code in this PR do / what does it improve?
This PR adds new fields of S1 pattern likelihoods for alt S1, which are
"alt_s1_2llh"
,"alt_s1_top_2llh"
,"alt_s1_bottom_2llh"
. They could be useful for s1 single scatter cut.Can you briefly describe how it works?
For alt S1's calculation, most of the changes are just with a prefix
"alt_"
. The only exception is z, with prefix"alt_s1_"
.Can you give a minimal working example (or illustrate with a figure)?
Same as before
Please include the following if applicable: