-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed save type and bootstrax #1440
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before this change, the target
and post_process
for nv calibration runs were both set to raw_records
as the default. Now they are both set to raw_records_nv
, which is without the software coincidence trigger. This PR looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tests fail as the NV data is not available - we only downloaded one commissioning run for the test:
Lines 16 to 27 in 9813b30
nt_test_run_id = "012882" | |
@export | |
def download_test_data( | |
test_data="https://raw.githubusercontent.com/XENONnT/strax_auxiliary_files/353b2c60a01e96f67e4ba544ce284bd91241964d/strax_files/strax_test_data_straxv1.1.0.tar", # noqa | |
): | |
"""Downloads strax test data to strax_test_data in the current directory.""" | |
blob = straxen.common.get_resource(test_data, fmt="binary") | |
f = io.BytesIO(blob) | |
tf = tarfile.open(fileobj=f) | |
tf.extractall() |
And currently all tests are using this run, which is hardcoded in the
/tests/plugins
moduleShould we write a particular test for NV to solve the problem? @WenzDaniel
What does the code in this PR do / what does it improve?
Update bootstrax to ensure to not make software triggered data for calibrations.