Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed save type and bootstrax #1440

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Changed save type and bootstrax #1440

wants to merge 5 commits into from

Conversation

WenzDaniel
Copy link
Collaborator

What does the code in this PR do / what does it improve?

Update bootstrax to ensure to not make software triggered data for calibrations.

@yuema137 yuema137 self-requested a review November 26, 2024 23:38
yuema137
yuema137 previously approved these changes Dec 2, 2024
Copy link
Collaborator

@yuema137 yuema137 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before this change, the target and post_process for nv calibration runs were both set to raw_records as the default. Now they are both set to raw_records_nv, which is without the software coincidence trigger. This PR looks good to me.

@yuema137 yuema137 self-requested a review December 2, 2024 22:19
@yuema137 yuema137 dismissed their stale review December 2, 2024 22:19

Failure in the tests needs to be fixed

Copy link
Collaborator

@yuema137 yuema137 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests fail as the NV data is not available - we only downloaded one commissioning run for the test:

nt_test_run_id = "012882"
@export
def download_test_data(
test_data="https://raw.githubusercontent.com/XENONnT/strax_auxiliary_files/353b2c60a01e96f67e4ba544ce284bd91241964d/strax_files/strax_test_data_straxv1.1.0.tar", # noqa
):
"""Downloads strax test data to strax_test_data in the current directory."""
blob = straxen.common.get_resource(test_data, fmt="binary")
f = io.BytesIO(blob)
tf = tarfile.open(fileobj=f)
tf.extractall()

And currently all tests are using this run, which is hardcoded in the /tests/plugins module
Should we write a particular test for NV to solve the problem? @WenzDaniel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants