Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove GCN & CNN S2 pos-rec #1484

Merged
merged 4 commits into from
Nov 20, 2024
Merged

Remove GCN & CNN S2 pos-rec #1484

merged 4 commits into from
Nov 20, 2024

Conversation

dachengx
Copy link
Collaborator

@dachengx dachengx commented Nov 19, 2024 •
edited
Loading

We will only have MLP and CNF because it is very hard to maintain three pos-rec at the same time.

@dachengx dachengx changed the title Remove GCN & CNN pos-rec Remove GCN & CNN S2 pos-rec Nov 19, 2024
@coveralls
Copy link

coveralls commented Nov 19, 2024 •
edited
Loading

Coverage Status

coverage: 89.757% (-0.03%) from 89.785%
when pulling 38d0856 on rm_cnn_gcn
into e222b25 on master.

@dachengx dachengx changed the title Remove GCN & CNN S2 pos-rec Remove GCN & CNN S2 pos-rec and use CNF as default pos-rec Nov 19, 2024
@dachengx dachengx changed the title Remove GCN & CNN S2 pos-rec and use CNF as default pos-rec Remove GCN & CNN S2 pos-rec Nov 20, 2024
@dachengx dachengx marked this pull request as ready for review November 20, 2024 00:20
juehang
juehang approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@juehang juehang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I don't see any issues.

@dachengx dachengx merged commit b18d972 into master Nov 20, 2024
8 checks passed
@dachengx dachengx deleted the rm_cnn_gcn branch November 20, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebvetter sebvetter sebvetter approved these changes

@LuisSanchez25 LuisSanchez25 LuisSanchez25 approved these changes

@juehang juehang juehang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dachengx @coveralls @juehang @LuisSanchez25 @sebvetter