Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move set_nan_defaults to be a stand-alone function #1497

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

dachengx
Copy link
Collaborator

Before you submit this PR: make sure to put all operations-related information in a wiki-note, a PR should be about code and is publicly accessible

What does the code in this PR do / what does it improve?

Depends on AxFoundation/strax#936

Close: #1491

Can you briefly describe how it works?

Can you give a minimal working example (or illustrate with a figure)?

Please include the following if applicable:

  • Update the docstring(s)
  • Update the documentation
  • Tests to check the (new) code is working as desired.
  • Does it solve one of the open issues on github?

Notes on testing

  • Until the automated tests pass, please mark the PR as a draft.
  • On the XENONnT fork we test with database access, on private forks there is no database access for security considerations.

All italic comments can be removed from this template.

@coveralls
Copy link

Coverage Status

coverage: 89.491% (+0.01%) from 89.48%
when pulling 7ac39f8 on move_set_nan_defaults
into f765c10 on master.

@dachengx dachengx marked this pull request as ready for review December 16, 2024 04:38
@dachengx dachengx merged commit 5704361 into master Dec 16, 2024
8 checks passed
@dachengx dachengx deleted the move_set_nan_defaults branch December 16, 2024 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move set_nan_defaults to be a stand-alone function
2 participants