Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Back to fixed window in LED calibration #1499

Merged
merged 2 commits into from
Dec 16, 2024
Merged

Conversation

GiovanniVolta
Copy link
Contributor

@GiovanniVolta GiovanniVolta commented Dec 16, 2024

What does the code in this PR do / what does it improve?

We did not identify the reasons for the gain changes with the dynamic window (see here) therefore we are proposing to go back to the fixed window.
The proposed window is [78,142] based on this study.
Note that I did not remove the dynamic window code since I hope we can understand the problem, adjust the code and use it for the future.

Please include the following if applicable:

  • Update the docstring(s)
  • Update the documentation
  • Tests to check the (new) code is working as desired.
  • Does it solve one of the open issues on github?

Notes on testing

  • Until the automated tests pass, please mark the PR as a draft.
  • On the XENONnT fork we test with database access, on private forks there is no database access for security considerations.

@coveralls
Copy link

coveralls commented Dec 16, 2024

Coverage Status

coverage: 89.514% (+0.03%) from 89.488%
when pulling cd829a0 on back_to_fixed_window
into 7138149 on master.

@GiovanniVolta GiovanniVolta changed the title did pushed back to fixed window Dec 16, 2024
@dachengx dachengx changed the title back to fixed window Back to fixed window in LED calibration Dec 16, 2024
Copy link
Collaborator

@dachengx dachengx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much @GiovanniVolta !

@dachengx dachengx merged commit 951856b into master Dec 16, 2024
8 checks passed
@dachengx dachengx deleted the back_to_fixed_window branch December 16, 2024 16:11
@GiovanniVolta
Copy link
Contributor Author

GiovanniVolta commented Dec 16, 2024

Just to be sure I have checked once more the gain and occupancy with the default plugin, and it looks good
immagine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants