Back to fixed window in LED calibration #1499
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the code in this PR do / what does it improve?
We did not identify the reasons for the gain changes with the dynamic window (see here) therefore we are proposing to go back to the fixed window.
The proposed window is [78,142] based on this study.
Note that I did not remove the dynamic window code since I hope we can understand the problem, adjust the code and use it for the future.
Please include the following if applicable:
Notes on testing