dev: move binding_conversion dict to aliases, remove irrelevant comment

- feedback from PR #685
XLSForm · Feb 8, 2024 · 64903fd · 64903fd
1 parent b7c496a
commit 64903fd
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 18 deletions.
diff --git a/pyxform/aliases.py b/pyxform/aliases.py
@@ -180,3 +180,17 @@
     "username",
 ]
 osm = {"osm": constants.OSM_TYPE}
+BINDING_CONVERSIONS = {
+    "yes": "true()",
+    "Yes": "true()",
+    "YES": "true()",
+    "true": "true()",
+    "True": "true()",
+    "TRUE": "true()",
+    "no": "false()",
+    "No": "false()",
+    "NO": "false()",
+    "false": "false()",
+    "False": "false()",
+    "FALSE": "false()",
+}
diff --git a/pyxform/builder.py b/pyxform/builder.py
@@ -75,8 +75,6 @@ def copy_json_dict(json_dict):
 
 
 class SurveyElementBuilder:
-    # we use this CLASSES dict to create questions from dictionaries
-
     def __init__(self, **kwargs):
         # I don't know why we would need an explicit none option for
         # select alls

diff --git a/pyxform/constants.py b/pyxform/constants.py
@@ -148,20 +148,6 @@ class EntityColumns(StrEnum):
     "becomes '_setting'."
 )
 
-BINDING_CONVERSIONS = {
-    "yes": "true()",
-    "Yes": "true()",
-    "YES": "true()",
-    "true": "true()",
-    "True": "true()",
-    "TRUE": "true()",
-    "no": "false()",
-    "No": "false()",
-    "NO": "false()",
-    "false": "false()",
-    "False": "false()",
-    "FALSE": "false()",
-}
 CONVERTIBLE_BIND_ATTRIBUTES = (
     "readonly",
     "required",

diff --git a/pyxform/survey_element.py b/pyxform/survey_element.py
@@ -7,6 +7,7 @@
 from functools import lru_cache
 from typing import TYPE_CHECKING, Any, ClassVar, Dict, List
 
+from pyxform import aliases as alias
 from pyxform import constants as const
 from pyxform.errors import PyXFormError
 from pyxform.question_type_dictionary import QUESTION_TYPE_DICT
@@ -443,10 +444,10 @@ def xml_bindings(self):
                 # the xls2json side.
                 if (
                     hashable(v)
-                    and v in const.BINDING_CONVERSIONS
+                    and v in alias.BINDING_CONVERSIONS
                     and k in const.CONVERTIBLE_BIND_ATTRIBUTES
                 ):
-                    v = const.BINDING_CONVERSIONS[v]
+                    v = alias.BINDING_CONVERSIONS[v]
                 if k == "jr:constraintMsg" and (
                     isinstance(v, dict) or re.search(BRACKETED_TAG_REGEX, v)
                 ):