Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

603: (secondary instances) fix or_other + translations + group or repeat #650

Merged
merged 3 commits into from
Aug 29, 2023

Commits on Aug 25, 2023

  1. fix: failure when using or_other + translations + group or repeat

    - in _create_section_from_dict, the context is the nearest "section"
      which can be a survey, group, or repeat. When it's not the survey,
      the survey-level choices dict isn't directly available. So this is
      now tracked by the builder as a class-level object.
    - added tests for groups, repeats, groups-in-groups, repeats-in-groups.
    lindsay-stevens committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    fd132be View commit details
    Browse the repository at this point in the history
  2. dev: use string constants in builder.py

    - standardise to help avoid misspelling / refactoring issues in future
    lindsay-stevens committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    f411aea View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2023

  1. add: warning when using or_other and translations together

    - warning is once per form. Re-used missing translations check code
      to avoid doing the same processing twice. The new check needed the
      intermediate result of the missing check.
    - test_validators.py: removed version check for import since supported
      versions have been above 3.3 for a while.
    lindsay-stevens committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    437e7c2 View commit details
    Browse the repository at this point in the history