Upgrade Validate to reduce file size #723
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses comments at #720 (comment)
Updates changelog in preparation for release
Verified this using https://docs.google.com/spreadsheets/d/1FOlADSaTTUOhsbeQDcU5HZrJfzseVYwBMdTIz1Skmkw/edit?gid=1068911091#gid=1068911091
Why is this the best possible solution? Were any other approaches considered?
This reduces Validate's size down to 3.9 MB. I think that's a good balance between benefit and time spent for now. We can come back to getodk/validate#92
What are the regression risks?
Most likely would be with the
extract-signed
function but I think the form I tried is enough.Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have:
tests
python -m unittest
and verified all tests passruff format pyxform tests
andruff check pyxform tests
to lint code