Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Validate to reduce file size #723

Merged
merged 2 commits into from
Sep 9, 2024

Conversation

lognaturel
Copy link
Contributor

@lognaturel lognaturel commented Sep 9, 2024

Addresses comments at #720 (comment)

Updates changelog in preparation for release

Verified this using https://docs.google.com/spreadsheets/d/1FOlADSaTTUOhsbeQDcU5HZrJfzseVYwBMdTIz1Skmkw/edit?gid=1068911091#gid=1068911091

Why is this the best possible solution? Were any other approaches considered?

This reduces Validate's size down to 3.9 MB. I think that's a good balance between benefit and time spent for now. We can come back to getodk/validate#92

What are the regression risks?

Most likely would be with the extract-signed function but I think the form I tried is enough.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No.

Before submitting this PR, please make sure you have:

  • included test cases for core behavior and edge cases in tests
  • run python -m unittest and verified all tests pass
  • run ruff format pyxform tests and ruff check pyxform tests to lint code
  • verified that any code or assets from external sources are properly credited in comments

@lindsay-stevens
Copy link
Contributor

Amazing!

@lindsay-stevens lindsay-stevens merged commit e1ed282 into XLSForm:master Sep 9, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants