#252 - code review suggestions

XLabs · Jul 20, 2023 · bb33e3b · bb33e3b
1 parent b40ad3b
commit bb33e3b
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 9 deletions.
diff --git a/src/components/Recovery.tsx b/src/components/Recovery.tsx
@@ -559,7 +559,7 @@ export default function Recovery() {
     useState(false);
   const [recoverySourceTxError, setRecoverySourceTxError] = useState("");
   const [recoverySignedVAA, setRecoverySignedVAA] = useState("");
-  const { itIsNFTTransfer, itIsTokenBridgeTransfer } =
+  const { isNFTTransfer, isTokenBridgeTransfer } =
     useVaaVerifier(recoverySignedVAA);
   const [recoveryParsedVAA, setRecoveryParsedVAA] = useState<ParsedVaa | null>(
     null
@@ -908,7 +908,7 @@ export default function Recovery() {
   const enableRecovery =
     recoverySignedVAA &&
     parsedPayloadTargetChain &&
-    (itIsNFTTransfer || itIsTokenBridgeTransfer);
+    (isNFTTransfer || isTokenBridgeTransfer);
 
   const handleRecoverClickBase = useCallback(
     (useRelayer: boolean) => {

diff --git a/src/hooks/useVaaVerifier.ts b/src/hooks/useVaaVerifier.ts
@@ -78,7 +78,7 @@ function itWasEmittedFrom(
   return false;
 }
 
-function itIsASupportedType(
+function isItASupportedType(
   type: VAAType,
   ...supportedTypes: VAAType[]
 ): boolean {
@@ -95,34 +95,34 @@ export function useVaaVerifier(hexVaa: string) {
     [vaa]
   );
   const payloadType = useMemo(() => getPayloadType(vaa?.payload), [vaa]);
-  const itIsTokenBridgeTransfer = useMemo(
+  const isTokenBridgeTransfer = useMemo(
     () =>
       itWasEmittedFrom(
         vaaEmitterAddress,
         vaaEmitterChain,
         getTokenBridgeAddressForChain
       ) &&
-      itIsASupportedType(
+      isItASupportedType(
         payloadType,
         VAAType.TRANSFER,
         VAAType.TRANSFER_WITH_PAYLOAD
       ),
     [vaaEmitterAddress, vaaEmitterChain, payloadType]
   );
-  const itIsNFTTransfer = useMemo(
+  const isNFTTransfer = useMemo(
     () =>
       itWasEmittedFrom(
         vaaEmitterAddress,
         vaaEmitterChain,
         getNFTBridgeAddressForChain
-      ) && itIsASupportedType(payloadType, VAAType.TRANSFER),
+      ) && isItASupportedType(payloadType, VAAType.TRANSFER),
     [vaaEmitterAddress, vaaEmitterChain, payloadType]
   );
   return {
     transfer,
     nft,
     payloadType,
-    itIsTokenBridgeTransfer,
-    itIsNFTTransfer,
+    isTokenBridgeTransfer,
+    isNFTTransfer,
   };
 }