Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add warning on redeem attempt for non supported vaa's #252

Closed
mliu-xlabs opened this issue Jul 18, 2023 · 2 comments
Closed

add warning on redeem attempt for non supported vaa's #252

mliu-xlabs opened this issue Jul 18, 2023 · 2 comments

Comments

@mliu-xlabs
Copy link
Collaborator

CCTP tx

  • 0xc0f4396538cc5aaf0331fd7b8f1b88777f8eff295f3153e6ab6335759777a395
01000000030d0087628e8a2330a67e80fe5b289021430da29f7892534561e652655a878ad6e09616b17c458518d69a5dce39d20f0dcab988dd158d80eb1b7c07288a7fce4c1f490003798aabe2246e36e7ebfcf9e19f1ccd85269a2f666c136580c8449657699d37ce1fd16fae40634f6e2ddb940271c0cb5c29d8c2404f3a328c04ae6512c7f0b4eb0004404ddafcfac5d9caa3291b2f8d22ef488d13c00aa0b880762cb9071b72d57fbb0316a8d50c70b8656de8eca7c1c42b35c320b7d44557ff8e715421a4ce80022d010571626487d850de8ddfe1c34458138668d6cf5d00022e5a07720640dcea99fb330ac830de0a819aebf6036a3d75e408a27e6e7e4f1c4178def89447cfb3d783e9010663a528d84325d5cc9aceea0255c7343c65feec5715028367fa0b5393f530c3581b47018a3dc31676d8869ff555301ecc21941208d2fdf4d5789c12ffa2b9a70801076ee678282c30443516ac1dd37a1f0b5451c54f43c6b5eb61abad965ea7d95c2a718f81d4a12d208f2059ce137222fc029df0cdcd6c96b34081ae7c94fc80f48e0008a2f0ce0f5eacc928e31db48b0806ef6c3b14d11b3f50b736740c4207ed614a3d165befe2c1ac95bcc1f98d659743ecb8321ba0468d3b0e21b800dd554313786f010953db94a06dc486c6be585c2cd8bc0e64c677454b65cc9556c08e6bb7556def662023c79ee5f744a0bc87a8208f3398861cf092fbfa020011b9c5053d36e9dedc010c01f4ac438664bb109b35a8b05448d261720141e6ffd244c9f61c3fbee62726e10f6069b84c05d23abdf5986c8928ae2e5796e0f27a3cbd0e42ee7b542ab666ef010d7a85241f0be92c618967ef9c31030bea08dc45c5d2ed586b64cf5c969727dbee27489061480cdaf89cdfd5317a4dc94be848b1b38af021e52ff71498fc12cad600102faf98ebe5c57f61077587a7d90fadafcd94077235226fedd1ac5cfd2528fc0c5f2dc8ba9481634f0554bb234ecdee3d81556eabb8fe7a3491a0c3f650937f1e00113d6f090abcc0b98aa452e6326b82143cf89f49abbf9bec0ce95bc395bbf60d4041b6036d5884e6df89b074f6cf5e40da0638809724bf55aa43fb9edc23a8754a0112b3619fd7ebd297d2a8b0a84daa5921525487c79384c790a04bab64834cd385d66174a852e5d14cd3dad8262a2b5f0ecc9863b288877563214d09c6ebe77ce0270164aff1ac00000000000600000000000000000000000009fb06a271faff70a651047395aaeb6265265f1300000000000000f10101000000000000000000000000b97ef9ef8734c71904d8002f8b6bc66dd9c48a6e0000000000000000000000000000000000000000000000000000000043b325bc000000010000000300000000000007650000000000000000000000004cb69fae7e7af841e44e1a1c30af640739378bb20000000000000000000000004cb69fae7e7af841e44e1a1c30af640739378bb200610100000000000000000000000000000000000000000000000000000000000f424000000000000000000000000000000000000000000000000000000000000000000000000000000000000000002921f6d14dae58f7df46b5340d3d132669a68edd

Wormhole Connect Tx

  • 0xefc0a0a83f311515e42c486792f5f0fd372decdf896a1be4ed9808b01e8f6827
01000000030d00fadc7c0c87f87b3f12f5737874f28f0312db7de91e9d5d4ae47d7e613b51f5ed57c612166fd6a63915dfbf7cca30006165c70415fc248cefff0fa4eda8a23a9900013a7ba158d261c7af6c5ee8a6077459570291f1b3371c8b1a789ebbc2be4dc36f1385d2f02fd0d67e4443a7307600b78d5539ee32330144c82f077a54ff88e9f00002988f4329a2bda66ab1b593b39638b37e050dd530928f7dcda00920fb9035cb4419d7dfd0c6cccaf77a2272204138907179d4715585ae4cc547420be27ccda26a0003754930aafb7d9df56169e55f23a99bf91212c5236add96dc8b076e7fd5db3a987a684344f8f722607e5108668e055b1f07fd30d3b81b9a18a6efe088730edd8401043892c8467547a8c8c93ed633c046a96f223fdd0b8cd2b1e0ff92885948122018192225d78a423695ceb96079dc4bc5e08375357813ac06d53de3d745dac7c27001067f9886723125f01673ebc454cd8ab6b2792b25395ade0bf88812b5b65f14685d62cfa0219ad71014e51be098422955913b67bd1531440d195f4f4e89946b990c000adc6521b2015b4e4a83b844519ebdc5b3a03f82266d036b271f12387ab5e6bb8539e19471c586afcd4bf455647f244edf85db7b45935faa35b9dd54b8413f0aaf000ce77934f5197df752afe58cff6508578a6d1799414ae91f8b468c22cd6cc703916ba90406a4c7e1a64e112889b3ddcdd312f3c28393f1cc0555ac2757c89df04c010dbe2de06051e6d9c276af6ad7ef77b3457427819bc2508d8fbdcfb4aa4e24e0001d0e725c37d2a24f0177d369ffaf6ca35ff7811dece71442c365504de6ed65a4010ec2c58041a435c687d34be4968e783b95e8810bd2350b208212e3390a054d21154fc9ea2c58a32fee2407e726a8105354a804241fc1eee71b108d8678538c36a5001021ae2fc4f96262658c6e51b87403e5fa103e05b2b2838e20176aece1fc577ceb2b2afb72618bd0f7a7847dc750f4a2a6285e7362ea01db653bbab343787987c80111a5fa57429c4684df176a64696297992e44098be0247c5ec6323e5b7318c1baee4f19879d86dcc3ed7eefd72e274805e7b8a4eeccaad49b6b6963fa5f8fda56700112db9d59c7f28a1855f98b3fcab992c6c98a1d65a97f2abe6a76ee742123b7d4871bca19cb30b0ba9a373512b627bcd254ee5cfa98c74acd07fd7b5553419ed0ba0164b5232e000000000004000000000000000000000000b6f6d86a8f9879a9c87f643768d9efc38c1da6e7000000000003f3bc0f0300000000000000000000000000000000000000000000000000000000000f4240000000000000000000000000bb4cdb9cbd36b01bd1cbaebf2de08d9173bc095c000444cd5861a6732696d2122e5d1123c3b86c8146c2fe78fd957378fc9ce28b9c410015000000000000000000000000461a8878060aa45fa685732bff654ca1fdef2830010000000000000000000000000000000000000000000000000000000000027da600000000000000000000000000000000000000000000000000000000000174a8b015fa37f8290465ae8e73fa5bcb33a54ab9559ec7be10be8edcf1e95ff9bbc9

Other to review

  • 0x9c27a9904ebfaabc95783c85155c819e78036e968966c359ae41dc0fca149127
01000000030d00199e8487f42ab79a32a288d929aaf9462dd66b3256e4344cbb771f106d7f75927cf5b70adc1a26cbc950f7d1e2ca907b7002af3414c9572d6a15e235a78c26ee01029bc1151c757516afed35c858cb924e1791f7f2fd4d865d4b139660ff8932d36a4997fc8f0f3260b517737c5072e92c3d5d12b24a7ade8b2b3f0d9f5002651cad0003bcb3c399a536a27ea2be323f4fe83cefcc7d47887cf4493622957ee0d1ed2e9a4d0b837d1d90f25a458e2a4f4d7df8200ec97ea41fb22cbc028ec79453bc14030104054db7896ca1b8052591b3e668d29c891b4a23076998d965170dff25b312def2614cfde8b824011862c06b75df250e87bac685c00bd346569527d622f13d1dbd0106ef7fa7f7f8c4611ea099b3727b44d67c226887c9bf130f9404bd1cb3c3c7a0f96b66efc3d7a01415a639377c3f67c04f7acc0febe535df51d18df84cc55c2488000a67c87a20e3e862b49a91dd8908d263d16d0436cb7f0e9e204dbbec04328a053e5db5d193dd6ae43876276f3587de5ac62a31c23762ae4fc29c7349b568f89ec9010c3ce348eb825f9ab1f882ad594b86c6aa8f49254394b8e56a679ce8819e8c355e10395918fd1ea4a5c3b0b3e5a0dcb0b357e7bc9c7a2e6421f6f0e91f9799df42010d55f65fdef85bf62edc6105209228281131988ebca771ff3e8062b9cc5f5b0cae700a012f41f8b32e601371795286c50345150c83390501a2ff02cf5c59ed5a69010ee5c92abc86826bcd5c4746547d9aebb9eb9ade205881439256fe96390df244d6296392f01d78e20696a255657fad6776d1ee4695c68588ce2586fce3b46a2821000fb7455239ee4bf0771f45ea0d24171eca149d0f224feba41a88576d5020e50e411c74850280f7b4a257b51deacba25c34cc7a93c069f3c77a6c16e4f06345346400100fa4dd9e2960b4541cc997412a5a1c925526ab94897c2881c2336bf11dd5aceb52a1fb2c33bf38c529b5ad4c390e4bd44b8283cfb56464d4d412c09dffdde9dd0011ee0a7247dd5613ea9a8c693a150315978be6316162c617e361a8e6e307edf81c0eb2b84bcc85ab3bcd9089d1402e21f0efdc2a0475acb2c2d6c0239a93e44f310012ef7451106d403dfec73b1790b60ab7f88bf58bce008ddd7d6fee2fc8426b13d561fdab7273653376b8fd5d1f4d9f465a7766c40f1fec49d499669f3ebd5719230064b1595388a1000000020000000000000000000000003ee18b2214aff97000d974cf647e7c347e8fa585000000000001cf5b01010000000000000000000000000000000000000000000000000000000000f5ace7000000000000000000000000c02aaa39b223fe8d0a0e5c4f27ead9083c756cc2000200000000000000000000000088a5696c4b898f0ebc70a9de8ea84c194c944eaf000300000000000000000000000000000000000000000000000000000000000188e7
@mliu-xlabs
Copy link
Collaborator Author

is this covered elsewhere by messaging? whats the difference here?

sebastianscatularo added a commit that referenced this issue Jul 18, 2023
@sebastianscatularo
#252 - add warning for VAAs not compatible with token bridge to be re…
30ecd63 
…deemed, like CCTP for instance
sebastianscatularo added a commit that referenced this issue Jul 18, 2023
@sebastianscatularo
#252 - prettier fix
b40ad3b
sebastianscatularo added a commit that referenced this issue Jul 20, 2023
@sebastianscatularo
#252 - code review suggestions
bb33e3b
sebastianscatularo added a commit that referenced this issue Jul 20, 2023
@sebastianscatularo
#252 - add warning for VAAs not compatible (#253)
a7da986 
* #252 - add warning for VAAs not compatible with token bridge to be redeemed, like CCTP for instance

* #252 - prettier fix

* #252 - code review suggestions
@sebastianscatularo
Copy link
Contributor

duplicated of #246, closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sebastianscatularo @mliu-xlabs