-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch WalletConnect to v2 #223
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
M-Picco
temporarily deployed
to
Cloudflare-Testnet
July 3, 2023 19:45
— with
GitHub Actions
Inactive
M-Picco
temporarily deployed
to
Cloudflare-Testnet
July 3, 2023 19:45
— with
GitHub Actions
Inactive
M-Picco
temporarily deployed
to
Cloudflare-Preview
July 3, 2023 19:45
— with
GitHub Actions
Inactive
M-Picco
temporarily deployed
to
Cloudflare-Preview
July 3, 2023 19:45
— with
GitHub Actions
Inactive
M-Picco
temporarily deployed
to
Cloudflare-Testnet
July 3, 2023 19:55
— with
GitHub Actions
Inactive
M-Picco
temporarily deployed
to
Cloudflare-Preview
July 3, 2023 19:55
— with
GitHub Actions
Inactive
sebastianscatularo
approved these changes
Jul 3, 2023
valentinoConti
approved these changes
Jul 3, 2023
M-Picco
temporarily deployed
to
Cloudflare-Preview
July 7, 2023 17:37
— with
GitHub Actions
Inactive
M-Picco
temporarily deployed
to
Cloudflare-Testnet
July 7, 2023 17:37
— with
GitHub Actions
Inactive
M-Picco
temporarily deployed
to
Cloudflare-Preview
July 7, 2023 17:38
— with
GitHub Actions
Inactive
M-Picco
temporarily deployed
to
Cloudflare-Testnet
July 7, 2023 17:38
— with
GitHub Actions
Inactive
M-Picco
temporarily deployed
to
Cloudflare-Testnet
July 7, 2023 17:47
— with
GitHub Actions
Inactive
M-Picco
temporarily deployed
to
Cloudflare-Preview
July 7, 2023 17:48
— with
GitHub Actions
Inactive
M-Picco
temporarily deployed
to
Cloudflare-Testnet
July 7, 2023 20:59
— with
GitHub Actions
Inactive
M-Picco
temporarily deployed
to
Cloudflare-Testnet
July 7, 2023 20:59
— with
GitHub Actions
Inactive
M-Picco
force-pushed
the
wallet-connect-v2
branch
from
July 7, 2023 21:11
da577c5
to
6c0f8a2
Compare
M-Picco
temporarily deployed
to
Cloudflare-Preview
July 7, 2023 21:11
— with
GitHub Actions
Inactive
M-Picco
temporarily deployed
to
Cloudflare-Testnet
July 7, 2023 21:11
— with
GitHub Actions
Inactive
M-Picco
temporarily deployed
to
Cloudflare-Testnet
July 7, 2023 21:11
— with
GitHub Actions
Inactive
M-Picco
temporarily deployed
to
Cloudflare-Preview
July 7, 2023 21:11
— with
GitHub Actions
Inactive
M-Picco
temporarily deployed
to
Cloudflare-Testnet
July 7, 2023 21:21
— with
GitHub Actions
Inactive
M-Picco
temporarily deployed
to
Cloudflare-Preview
July 7, 2023 21:22
— with
GitHub Actions
Inactive
M-Picco
requested a deployment
to
Cloudflare-Preview
July 10, 2023 20:13
— with
GitHub Actions
Abandoned
M-Picco
temporarily deployed
to
Cloudflare-Preview
July 10, 2023 20:13
— with
GitHub Actions
Inactive
M-Picco
force-pushed
the
wallet-connect-v2
branch
from
July 12, 2023 18:50
6c0f8a2
to
d4c498a
Compare
M-Picco
temporarily deployed
to
Cloudflare-Preview
July 12, 2023 18:50
— with
GitHub Actions
Inactive
M-Picco
temporarily deployed
to
Cloudflare-Testnet
July 12, 2023 18:50
— with
GitHub Actions
Inactive
M-Picco
temporarily deployed
to
Cloudflare-Preview
July 12, 2023 18:50
— with
GitHub Actions
Inactive
M-Picco
temporarily deployed
to
Cloudflare-Testnet
July 12, 2023 18:50
— with
GitHub Actions
Inactive
M-Picco
temporarily deployed
to
Cloudflare-Preview
July 12, 2023 19:04
— with
GitHub Actions
Inactive
M-Picco
temporarily deployed
to
Cloudflare-Testnet
July 12, 2023 19:05
— with
GitHub Actions
Inactive
sebastianscatularo
temporarily deployed
to
Cloudflare-Testnet
July 12, 2023 19:11
— with
GitHub Actions
Inactive
sebastianscatularo
temporarily deployed
to
Cloudflare-Preview
July 12, 2023 19:11
— with
GitHub Actions
Inactive
sebastianscatularo
temporarily deployed
to
Cloudflare-Testnet
July 12, 2023 19:11
— with
GitHub Actions
Inactive
sebastianscatularo
temporarily deployed
to
Cloudflare-Preview
July 12, 2023 19:11
— with
GitHub Actions
Inactive
sebastianscatularo
temporarily deployed
to
Cloudflare-Testnet
July 12, 2023 19:21
— with
GitHub Actions
Inactive
sebastianscatularo
temporarily deployed
to
Cloudflare-Preview
July 12, 2023 19:24
— with
GitHub Actions
Inactive
sebastianscatularo
temporarily deployed
to
Cloudflare-Testnet
July 12, 2023 19:43
— with
GitHub Actions
Inactive
sebastianscatularo
temporarily deployed
to
Cloudflare-Preview
July 12, 2023 19:43
— with
GitHub Actions
Inactive
sebastianscatularo
temporarily deployed
to
Cloudflare-Testnet
July 12, 2023 19:43
— with
GitHub Actions
Inactive
sebastianscatularo
temporarily deployed
to
Cloudflare-Preview
July 12, 2023 19:43
— with
GitHub Actions
Inactive
sebastianscatularo
temporarily deployed
to
Cloudflare-Testnet
July 12, 2023 19:55
— with
GitHub Actions
Inactive
sebastianscatularo
temporarily deployed
to
Cloudflare-Preview
July 12, 2023 19:56
— with
GitHub Actions
Inactive
sebastianscatularo
temporarily deployed
to
Cloudflare-Testnet
July 12, 2023 20:12
— with
GitHub Actions
Inactive
sebastianscatularo
temporarily deployed
to
Cloudflare-Preview
July 12, 2023 20:12
— with
GitHub Actions
Inactive
sebastianscatularo
temporarily deployed
to
Cloudflare-Testnet
July 12, 2023 20:12
— with
GitHub Actions
Inactive
sebastianscatularo
temporarily deployed
to
Cloudflare-Preview
July 12, 2023 20:12
— with
GitHub Actions
Inactive
sebastianscatularo
temporarily deployed
to
Cloudflare-Preview
July 12, 2023 20:23
— with
GitHub Actions
Inactive
sebastianscatularo
temporarily deployed
to
Cloudflare-Testnet
July 12, 2023 20:26
— with
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WalletConnect v1 has been shut down, and now all Dapps must migrate to v2.
Use the WalletConnectWallet from the aggregator sdk, instead of the legacy version. This wallet requires a project id to be configured, which will be injected through env vars.
I've also had to fiddle with the mui dialog z-index in order to keep it behind the wallet connect dialog; I couldn't find an option to modify the later's z-index, but I suppose we can also override it through an old, plain, css file.