#151 - add logic to disable button while wallets are in detection process

[sebastianscatularo]

add logic to disable the button while wallets are in the detection process

depends on: XLabs/wallet-aggregator-sdk#9

[valentinoConti]

Approved!

A comment just in case: I'm almost sure that I have seen on some chains the availableWallets variable be falsy but when pressing 'connect' some wallets still popped up to select;

maybe it would be a good idea to test every chain before merge to see if we are not preventing the connection for some chains 🙏🏼, and if that happens maybe after X minutes we can make the connect button available 🤔

[sebastianscatularo]

I've tested, and for the cases where availableWallets is falsy (availableWallets.length === 0), the button connect is disabled, using walletsNotAvailable, which is also watching for source chain changes to reset it, so you could have not detected wallets on sui, but once you change to ethereum, you want to see if there was detected wallets for ethereun, that is true, and for each case, you have a message.

Let me know if you have any other doubt and then we could merge it

151-test.mov

Screen.Recording.2023-07-07.at.11.45.32.mov

[valentinoConti]

Yes, what I meant is, for example in your video on the Aptos blockchain, you seem to have 'Snap' installed and thats why its available, and below you have lot of other wallets that show "Install X wallet"

If you don't have Snap installed, instead of showing the user the ones that can be installed, we are not going to show him anything and just disabling the connect button, right??

I mean that's still better than current behaviour but it's just a thought 🙌🏼, I think can be merged 👍🏼

[sebastianscatularo]

oh, I see your point, but this behavior is for detection, if we detect a mechanism to connect a wallet, we are good to go, maybe the message could be better, something like "we do not detect a wallet o mechanism to connect to a wallet ensure you have a wallet", but I'll keep that for a future PR