enforce minimum amount for Evm token transfers #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastianscatularo
temporarily deployed
to
Cloudflare-Preview
GitHub Actions
Inactive
sebastianscatularo
temporarily deployed
to
Cloudflare-Testnet
GitHub Actions
Inactive
sebastianscatularo
temporarily deployed
to
Cloudflare-Preview
GitHub Actions
Inactive
sebastianscatularo
temporarily deployed
to
Cloudflare-Testnet
GitHub Actions
Inactive
sebastianscatularo
requested review from
M-Picco,
raop155,
yuli-ferna and
valentinoConti
sebastianscatularo
temporarily deployed
to
Cloudflare-Preview
GitHub Actions
Inactive
sebastianscatularo
temporarily deployed
to
Cloudflare-Testnet
GitHub Actions
Inactive
valentinoConti
approved these changes
Aug 9, 2023
raop155
approved these changes
Aug 9, 2023
sebastianscatularo
force-pushed
the
bugs/enforce-minimum-amount-for-evm-tokens
branch
from
46937e6
to
1ca6879
Compare
sebastianscatularo
temporarily deployed
to
Cloudflare-Testnet
GitHub Actions
Inactive
sebastianscatularo
temporarily deployed
to
Cloudflare-Preview
GitHub Actions
Inactive
sebastianscatularo
temporarily deployed
to
Cloudflare-Testnet
GitHub Actions
Inactive
sebastianscatularo
temporarily deployed
to
Cloudflare-Preview
GitHub Actions
Inactive
sebastianscatularo
temporarily deployed
to
Cloudflare-Testnet
GitHub Actions
Inactive
sebastianscatularo
temporarily deployed
to
Cloudflare-Preview
GitHub Actions
Inactive
|
@SamantaCasal you could test it here https://testnet.portal-bridge-ui.pages.dev/3fe5de76dc/ |
yuli-ferna
approved these changes
Aug 14, 2023
gabzim
reviewed
Aug 14, 2023
src/components/Transfer/Source.tsx
Outdated
| @@ -260,6 +267,8 @@ function Source() { | |||
| value={amount} | |||
| onChange={handleAmountChange} | |||
| disabled={isTransferDisabled || shouldLockFields} | |||
| error={isBelowMinimum} | |||
| helperText={isBelowMinimum ? "Amount is below minimum" : ""} | |||
There was a problem hiding this comment.
Maybe the error message could be more helpful? “Amount sent is too small. The amount must be equal or greater than X.” Or something like that
There was a problem hiding this comment.
pushed an updated version with this change
|
QA Ok! Keep in mind, only 6 decimal places are shown in the dropdown to select tokens, then the balance is displayed 0.000000 |
sebastianscatularo
temporarily deployed
to
Cloudflare-Testnet
GitHub Actions
Inactive
sebastianscatularo
temporarily deployed
to
Cloudflare-Preview
GitHub Actions
Inactive
sebastianscatularo
temporarily deployed
to
Cloudflare-Testnet
GitHub Actions
Inactive
sebastianscatularo
temporarily deployed
to
Cloudflare-Preview
GitHub Actions
Inactive
sebastianscatularo
temporarily deployed
to
Cloudflare-Testnet
GitHub Actions
Inactive
sebastianscatularo
temporarily deployed
to
Cloudflare-Preview
GitHub Actions
Inactive
|
Ok! ❗ Fail wEth in Avalanche |
sebastianscatularo
temporarily deployed
to
Cloudflare-Testnet
GitHub Actions
Inactive
sebastianscatularo
temporarily deployed
to
Cloudflare-Testnet
GitHub Actions
Inactive
sebastianscatularo
temporarily deployed
to
Cloudflare-Preview
GitHub Actions
Inactive
sebastianscatularo
temporarily deployed
to
Cloudflare-Preview
GitHub Actions
Inactive
sebastianscatularo
temporarily deployed
to
Cloudflare-Testnet
GitHub Actions
Inactive
sebastianscatularo
temporarily deployed
to
Cloudflare-Preview
GitHub Actions
Inactive
|
ok! |
sebastianscatularo
force-pushed
the
bugs/enforce-minimum-amount-for-evm-tokens
branch
from
f3ff95f
to
f12c1cf
Compare
sebastianscatularo
added a commit
that referenced
this pull request
Aug 18, 2023
* Enforce minimum amount for evm token transfers * code review observations * fix decimals to the max supported for evm chains if the decimals are higher * [skip ci] - run prettier * code review observations * [skip ci] - cosmetic changes * disable next button if the amount is below minimum * [skip ci] - bump version
sebastianscatularo
deleted the
bugs/enforce-minimum-amount-for-evm-tokens
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For token transfers from Evm the maximum decimal supported at this moment is 8 decimals, which lends to a minimum amount of 0.00000001 to be possible to transfer, below that the Token Bridge contract rounds to zero. To avoid a lack of funds now the UI prevents users to input amounts below that amount.
see: https://github.com/wormhole-foundation/wormhole/blob/96682bdbeb7c87bfa110eade0554b3d8cbf788d2/ethereum/contracts/bridge/Bridge.sol#L259